Repository navigation
fix(desktop): remove dead experimental env setters - #321
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merging per the standing sweep directive: GitHub Actions is still producing zero runs repo-wide (fresh API check: total_count 0 for this PR's head SHA 8b10f7b), so the only reported check is CodeRabbit (pass) with the PR CLEAN/MERGEABLE. The change itself is verified: four deletions only — the two dead setters in |
Problem
Fixes #115. The desktop app set
OPENCODE_EXPERIMENTAL_ICON_DISCOVERY="true"andOPENCODE_EXPERIMENTAL_FILEWATCHER="true"into its environment on every launch (packages/desktop/src/main/lifecycle/environment.ts), intending to enable icon discovery and the file watcher for the servers it spawns — but nothing in the codebase reads either variable, and the English docs (cli.mdxExperimental table) promised both to users as working enable switches.packages/cli/src/server-process.tscomputesfilewatcher: !truthy(process.env.OPENCODE_FILEWATCHER_DISABLE ?? process.env.OPENCODE_DISABLE_FILEWATCHER). SettingOPENCODE_EXPERIMENTAL_FILEWATCHER=truecould never change anything.Solution
Direction 2 from the issue (remove the dead setters, align the docs), following the #103 precedent where the docs/setters were aligned with deliberate v2 behaviour:
environment.ts: drop both entries frompreferApplicationEnvironment;OPENCODE_CLIENT: "desktop"is unchanged. This is behaviour-neutral — the variables had no reader, so no spawned server can observe a difference.cli.mdx(English source): remove theOPENCODE_EXPERIMENTAL_ICON_DISCOVERYandOPENCODE_EXPERIMENTAL_FILEWATCHERrows from the Experimental table. Translations follow the usual docs-locale-sync flow, per the docs: OPENCODE_SERVER_USERNAME is promised but never read — basic-auth username is hardcoded to 'opencode' #103/docs: troubleshooting.mdx says the desktop app uses OPENCODE_PORT for its local server — nothing reads it #117 precedent.After this change, no launch-time setter in the desktop lifecycle names a variable nothing reads, and the docs no longer list either variable as a working enable switch — the acceptance criteria of #115. No test is added: the desktop package's testing rules prohibit source-grep/tombstone tests, and there is no behaviour to pin (the removed assignments were unobservable).
Verification
git grepfor both names across the tree, excluding locale docs: no matches remain (setter and English rows gone).Need help on this PR? Tag
@codesmith-botwith what you need.